feature: update restful api support update container diskquota #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
==========================================
- Coverage 15.36% 15.31% -0.06%
==========================================
Files 172 172
Lines 10630 10665 +35
==========================================
Hits 1633 1633
- Misses 8877 8912 +35
Partials 120 120
|
HusterWan
force-pushed
the
zr/update-env-fix
branch
from
7e6ede5 to
613d168
Compare
rudyfly
reviewed
Apr 27, 2018
daemon/mgr/container.go
Outdated
| @@ -908,6 +908,11 @@ func (mgr *ContainerManager) Update(ctx context.Context, name string, config *ty | |||
| } | |||
| } | |||
|
|
|||
| // update container disk quota | |||
| if err := mgr.updateContainerDiskQuota(ctx, c.meta, config.DiskQuota); err != nil { | |||
| return fmt.Errorf("failed to update container %s diskquota: %v", c.ID(), err) | |||
daemon/mgr/container.go
Outdated
|
|
||
| // set mount point disk quota | ||
| if err := mgr.setMountPointDiskQuota(ctx, c); err != nil { | ||
| return fmt.Errorf("failed to set mount point disk quota: %v", err) |
|
today, i will first merged this pr, then we should add some test case for update container disk quota. just record to remind myself |
HusterWan
force-pushed
the
zr/update-env-fix
branch
from
613d168 to
32d3401
Compare
Signed-off-by: Michael Wan <[email protected]>
HusterWan
force-pushed
the
zr/update-env-fix
branch
from
32d3401 to
65c918b
Compare
This was referenced May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
Update API should support update container diskquota
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews