Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: record container last exit time #1176

Merged
merged 1 commit into from
Apr 23, 2018
Merged

feature: record container last exit time #1176

merged 1 commit into from
Apr 23, 2018

Conversation

Ace-Tang
Copy link
Contributor

@Ace-Tang Ace-Tang commented Apr 22, 2018

Ⅰ. Describe what this PR did

record stopped container last exit time, like

$ pouch ps
Name     ID       Status                     Created          Image            Runtime
356700   356700   stopped (137) 36 minutes   36 minutes ago   busybox:latest   runc

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

record stopped or exited container last exit time, like

$ pouch ps
Name     ID       Status                     Created          Image            Runtime
356700   356700   Stopped (137) 36 minutes   36 minutes ago   busybox:latest   runc

Signed-off-by: Ace-Tang <[email protected]>
@pouchrobot pouchrobot added size/L and removed size/M labels Apr 22, 2018
@codecov-io
Copy link

Codecov Report

Merging #1176 into master will increase coverage by 0.07%.
The diff coverage is 68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   15.96%   16.04%   +0.07%     
==========================================
  Files         176      176              
  Lines       10133    10147      +14     
==========================================
+ Hits         1618     1628      +10     
- Misses       8397     8399       +2     
- Partials      118      120       +2
Impacted Files Coverage Δ
daemon/mgr/container_types.go 25.31% <68%> (+9.93%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 23, 2018
@allencloud allencloud merged commit 8797711 into AliyunContainerService:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants