feature: set volumes to /etc/mtab #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golint fails: And please also check the integration test. @rudyfly |
rudyfly
force-pushed
the
volume
branch
3 times, most recently
from
6e05eba to
f6a840b
Compare
allencloud
reviewed
Apr 22, 2018
daemon/mgr/spec_volume.go
Outdated
|
|
||
| "github.com/alibaba/pouch/storage/quota" |
There was a problem hiding this comment.
Please add a blank line below this line. Thanks a lot.
|
This will be conflict with pr #1154. Please pay attention. |
rudyfly
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 15.21% 15.15% -0.06%
==========================================
Files 172 172
Lines 10735 10772 +37
==========================================
Hits 1633 1633
- Misses 8981 9018 +37
Partials 121 121
|
rudyfly
changed the title
shaloulcy
reviewed
May 4, 2018
| continue | ||
| } | ||
|
|
||
| tempLine := fmt.Sprintf("/dev/v%02dd %s ext4 rw 0 0\n", i, m.Destination) |
There was a problem hiding this comment.
variable i should increase?
shaloulcy
reviewed
May 7, 2018
| @@ -10,6 +12,7 @@ import ( | |||
|
|
|||
| "github.com/alibaba/pouch/storage/quota" | |||
There was a problem hiding this comment.
add a blank line below this line, thanks a lot
set volumes to /etc/mtab in container, it makes the "df" command to show the volume's information. Signed-off-by: Rudy Zhang <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
set volumes to /etc/mtab in container, it makes the "df" command to show
the volume's information.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]