Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: make container exit with real exit code #1099

Merged
merged 1 commit into from
Apr 13, 2018
Merged

bugfix: make container exit with real exit code #1099

merged 1 commit into from
Apr 13, 2018

Conversation

Ace-Tang
Copy link
Contributor

@Ace-Tang Ace-Tang commented Apr 11, 2018

Fixes: #1075

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

  1. make container exit with real exit code
  2. fix stop wait after stdin close
  3. fix some test case hang, such as this will hang forever, miss detach flag.
-       command.PouchRun("run", "--name", name, "-m", "512M", "--enableLxcfs=true",
+       command.PouchRun("run", "-d", "--name", name, "-m", "512M", "--enableLxcfs=true",
  1. fix container exit code not equal 0 after container start

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/L labels Apr 11, 2018
1. make container exit with real exit code
2. fix stop wait after stdin close
3. fix some test case hang
4. fix container exit code not equal 0 after container start

Fixes: #1075

Signed-off-by: Ace-Tang <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1099 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   15.89%   15.48%   -0.42%     
==========================================
  Files         172      171       -1     
  Lines        9563     9597      +34     
==========================================
- Hits         1520     1486      -34     
- Misses       7933     8003      +70     
+ Partials      110      108       -2
Impacted Files Coverage Δ
cli/main.go 0% <0%> (ø) ⬆️
cli/run.go 0% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
cli/start.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 5% <0%> (-0.01%) ⬇️
pkg/utils/utils.go 75.64% <0%> (-2.52%) ⬇️
cli/command.go

@Ace-Tang
Copy link
Contributor Author

I fixed lots of test, please help to review them, @Letty5411 , thanks

@allencloud
Copy link
Collaborator

Please help to review this. @Letty5411

@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 13, 2018
@allencloud allencloud merged commit 6729e51 into AliyunContainerService:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Starting a container with exit value 11 should not return 0.
5 participants