Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:add container_top test #1093

Merged

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: jerryzhuang [email protected]

Ⅰ. Describe what this PR did

add container_top test

Ⅱ. Does this pull request fix one issue?

fixes: #966

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@zhuangqh Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @zhuangqh
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1093 into master will decrease coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   16.47%   15.86%   -0.62%     
==========================================
  Files         161      161              
  Lines        8921     8824      -97     
==========================================
- Hits         1470     1400      -70     
+ Misses       7347     7321      -26     
+ Partials      104      103       -1
Impacted Files Coverage Δ
client/container.go 0% <ø> (ø) ⬆️
client/container_top.go 100% <100%> (ø)
pkg/kernel/kernel.go 72.72% <0%> (-7.28%) ⬇️
pkg/utils/utils.go 75.6% <0%> (-6.46%) ⬇️
cli/command.go
client/client.go 35.48% <0%> (+6.91%) ⬆️

@ZouRui89
Copy link
Contributor

ZouRui89 commented Apr 11, 2018

Excellent work! LGTM
image

@allencloud
Copy link
Collaborator

allencloud commented Apr 11, 2018

Thanks for your review. @ZouRui89 LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 11, 2018
@allencloud allencloud merged commit 8818275 into AliyunContainerService:master Apr 11, 2018
@allencloud
Copy link
Collaborator

@zhuangqh
Please do not add substring fixes: #966 in your pr, since this pr does not fix the whole issue. It also fix just one part of the issue.
If you add the substring in the pr description, It means that you are fixing the while issue with this pr. And GitHub will automatically close the issue , once this pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] add mock test for client package
5 participants