Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with go report #1081

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Conversation

metayd
Copy link
Contributor

@metayd metayd commented Apr 9, 2018

Ⅰ. Describe what this PR did

fix some issues in go report, include ineffectual assignments and typos etc

Ⅱ. Does this pull request fix one issue?

fix #964

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @dbdd4us
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1081 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
+ Coverage   16.52%   16.56%   +0.03%     
==========================================
  Files         161      161              
  Lines        8884     8899      +15     
==========================================
+ Hits         1468     1474       +6     
- Misses       7313     7320       +7     
- Partials      103      105       +2
Impacted Files Coverage Δ
pkg/errtypes/errors.go 35.29% <ø> (ø) ⬆️
daemon/mgr/image.go 32.46% <0%> (+0.33%) ⬆️
ctrd/client.go 0% <0%> (ø) ⬆️
pkg/kernel/kernel.go 72.72% <0%> (-10.61%) ⬇️
client/client.go 28.57% <0%> (-4.77%) ⬇️
cli/command.go 0% <0%> (ø) ⬆️

@allencloud
Copy link
Collaborator

Could you help to check the prjquota part's code review? @rudyfly

@allencloud allencloud changed the title [WIP] fix issues with go report fix: issues with go report Apr 10, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Apr 10, 2018
@allencloud
Copy link
Collaborator

Thanks for your work. LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 10, 2018
@allencloud allencloud merged commit 30e9947 into AliyunContainerService:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GoReport Issue] fix issue for Pouch reported from GoReport
5 participants