Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish event to notify the server configuration changed and reset some configuration. #6129

Closed
KomachiSion opened this issue Jun 22, 2021 · 0 comments · Fixed by #6130
Closed
Labels
kind/enhancement Category issues or prs related to enhancement. kind/refactor
Milestone

Comments

@KomachiSion
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Some server configuration is defined on application.properties or JVM parameters, and get from EnvUtil.

Some config like DistroConfig, PushConfig and AuthConfig only set when server start.

So I think we can add an event to notify this Config when application.properties changed.

Describe the solution you'd like

  1. Can change some config without restarting.
  2. reduce frequently call EnvUtil.getProperties to reduce CPU cost.

Describe alternatives you've considered
Add an event when listen application.properties changed and EnvUtil has updated.

@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. kind/refactor labels Jun 22, 2021
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jun 22, 2021
@KomachiSion KomachiSion linked a pull request Jun 22, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement. kind/refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant