Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the namespaceId init way in nacosConfigService and nacosNamingService #4270

Closed
horizonzy opened this issue Nov 19, 2020 · 2 comments
Closed
Labels
status/duplicate This issue or pull request already exists

Comments

@horizonzy
Copy link
Collaborator

Describe the bug
In nacoConfigService, if user didn't set namespace in properties, it will use "" as default value.
In nacosNamingService, if user didn't set namespace in properites, it will use public str as default value.

Maybe we should unify the init way of namespace. make nacosConfigService to be same as naconsNamingService

@horizonzy
Copy link
Collaborator Author

in #4262, If we use public:*:* to replace ':*:*', when user didn't config namespace in properties, in naming module, it can work well, because the namespace will be set public. but in config module, it will cause problem, the namespace set as "". the permission can't pass.

@KomachiSion
Copy link
Collaborator

Move to #3525

@KomachiSion KomachiSion added status/duplicate This issue or pull request already exists and removed status/need discuss labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants