Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nacos/v1/ns/ops/metrics接口指标mem计算逻辑不对（3.2.3版本） #12374

Closed
kangzhaok opened this issue Jul 18, 2024 · 2 comments
Closed

nacos/v1/ns/ops/metrics接口指标mem计算逻辑不对（3.2.3版本） #12374

kangzhaok opened this issue Jul 18, 2024 · 2 comments
Assignees
@kangzhaok
Labels
contribution welcome kind/bug Category issues or prs related to bug.

Comments

@kangzhaok
Copy link
Contributor

通过nacos/v1/ns/ops/metrics查看注册中心指标，发现mem指标一直是1，查看代码计算逻辑是OperatingSystemBeanManager.getFreePhysicalMem / OperatingSystemBeanManager.getTotalPhysicalMem，应该改为（double）OperatingSystemBeanManager.getFreePhysicalMem / (double) OperatingSystemBeanManager.getTotalPhysicalMem
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. contribution welcome labels Jul 22, 2024
@kangzhaok
Copy link
Contributor Author

您好，这个可以分给我吗？
我已经提了pr了。

@HMYDK
Copy link
Contributor

HMYDK commented Jul 22, 2024

您好，这个可以分给我吗？ 我已经提了pr了。

pr中要关联issue，可以参考下其它pr

@kangzhaok kangzhaok mentioned this issue Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kangzhaok kangzhaok

Labels
contribution welcome kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HMYDK @kangzhaok @KomachiSion