Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we provide a configuration item for the maximum number of push retries, instead of directly hardcoding it to 50 times in the code? #10891

Closed
Bo-Qiu opened this issue Aug 1, 2023 · 5 comments

Comments

@Bo-Qiu
Copy link
Contributor

Bo-Qiu commented Aug 1, 2023

Is your feature request related to a problem? Please describe.
Should we provide a configuration item for the maximum number of push retries, instead of directly hardcoding it to 50 times in the code?

Describe the solution you'd like
Provide a configuration item for the maximum number of push retries, instead of directly hardcoding it to 50 times in the code.

Describe alternatives you've considered
Provide a configuration item for the maximum number of push retries, instead of directly hardcoding it to 50 times in the code.

Additional context
'''
image
'''

@Bo-Qiu
Copy link
Contributor Author

Bo-Qiu commented Aug 1, 2023

I will submit a PR, and if necessary, it can be merged.

@KomachiSion
Copy link
Collaborator

Should not, duplicate with #10727

@KomachiSion KomachiSion closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
@Bo-Qiu
Copy link
Contributor Author

Bo-Qiu commented Aug 1, 2023

But the task in the push configuration is set with a default retry limit of 50, not set to retry forever.

@Bo-Qiu
Copy link
Contributor Author

Bo-Qiu commented Aug 1, 2023

By the way, for configuration, the client will actively pull from the server side, so there won't be a situation where the data is inconsistent between the client and the server.

@KomachiSion KomachiSion reopened this Aug 1, 2023
@KomachiSion
Copy link
Collaborator

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants