Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to do HTTP health check use register instance port #10722

Closed
Joey777210 opened this issue Jul 3, 2023 · 8 comments · Fixed by #10799
Closed

How to do HTTP health check use register instance port #10722

Joey777210 opened this issue Jul 3, 2023 · 8 comments · Fixed by #10799
Labels
kind/question Category issues related to questions or problems

Comments

@Joey777210
Copy link
Contributor

Joey777210 commented Jul 3, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
When I use nacos for service discovery, I might want to config health check by HTTP.
Can I use the port that register by client? And How?
If can not be done, may be we can support this feature?

Describe the solution you'd like
A way to health check by client registered port.

截屏2023-07-03 19 10 27
@Joey777210 Joey777210 changed the title How to http health check use registered port How to do HTTP health check use register instance port Jul 3, 2023
@Daydreamer-ia
Copy link
Contributor

Daydreamer-ia commented Jul 4, 2023 •
edited
Loading

这种检查是服务端主动下探的，适用于永久服务；对于临时服务并不适用，临时实例是要求 sdk 主动上报的。

@Joey777210
Copy link
Contributor Author

@Daydreamer-ia 永久节点中似乎也没找到可以将Instance上报的port作为探活端口的配置方法

@KomachiSion
Copy link
Collaborator

image

使用ip端口进行检查设置为true，就会用注册的ip端口来进行检查。

@KomachiSion KomachiSion added the kind/question Category issues related to questions or problems label Jul 5, 2023
@Joey777210
Copy link
Contributor Author

Joey777210 commented Jul 6, 2023 •
edited
Loading

文案感觉不够清楚，我晚些提交pr修改下？

@KomachiSion
Copy link
Collaborator

老得文案如此，应该是考虑到意思和对齐平衡，再多加一些字，比如实例的，可能会过长。

@Joey777210
Copy link
Contributor Author

@KomachiSion 文案改成“使用注册端口检查” + 开启时把上面那个检查端口的输入ban掉，会不会清楚些？

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jul 13, 2023 •
edited
Loading

可以的，可以先改一下试试效果

@KomachiSion KomachiSion linked a pull request Jul 17, 2023 that will close this issue
[ISSUE_10722] HTTP health check use register instance port #10799
Merged
5 tasks
@KomachiSion
Copy link
Collaborator

Any PR for this issue？ @Joey777210 If #10799 has fix this PR, please close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/question Category issues related to questions or problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE_10722] HTTP health check use register instance port Joey777210/nacos
3 participants
@KomachiSion @Joey777210 @Daydreamer-ia