fix(json-schema): fix editable valid (#1679)

* fix(json-schema): fix editable valid * test(json-schema): add transform field props test
alibaba · Jun 29, 2021 · dbb2258 · dbb2258
1 parent 97577b5
commit dbb2258
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/packages/json-schema/src/__tests__/transformer.spec.ts b/packages/json-schema/src/__tests__/transformer.spec.ts
@@ -5,6 +5,38 @@ test('transform field props', () => {
     type: 'string',
   })
   expect(schema.toFieldProps()).not.toBeUndefined()
+  const schema2 = new Schema({
+    type: 'object',
+    properties: {
+      writeOnly: {
+        type: 'string',
+        writeOnly: true,
+      },
+      'x-editable': {
+        type: 'string',
+        'x-editable': true,
+      },
+      readOnly: {
+        type: 'string',
+        readOnly: true,
+      },
+      'x-read-only': {
+        type: 'string',
+        'x-read-only': true,
+      },
+      'x-read-pretty': {
+        type: 'string',
+        'x-read-pretty': true,
+      },
+    },
+  })
+  expect(schema2.properties['writeOnly'].toFieldProps().editable).toBeTruthy()
+  expect(schema2.properties['x-editable'].toFieldProps().editable).toBeTruthy()
+  expect(schema2.properties['readOnly'].toFieldProps().readOnly).toBeTruthy()
+  expect(schema2.properties['x-read-only'].toFieldProps().readOnly).toBeTruthy()
+  expect(
+    schema2.properties['x-read-pretty'].toFieldProps().readPretty
+  ).toBeTruthy()
 })
 
 test('transform required', () => {

diff --git a/packages/json-schema/src/transformer.ts b/packages/json-schema/src/transformer.ts
@@ -288,7 +288,7 @@ const getBaseProps = (
     props.dataSource = dataSource
   }
 
-  if (!isValid(editable)) {
+  if (isValid(editable)) {
     props.editable = editable
   }