fix(element): fix select label error (#2202)

* fix(element): fix select label error * feat(element): add form layout inline support
alibaba · Sep 21, 2021 · c8b513e · c8b513e
1 parent 94a6ffc
commit c8b513e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/packages/element/docs/demos/guide/select/template-async.vue b/packages/element/docs/demos/guide/select/template-async.vue
@@ -12,13 +12,13 @@
           },
         },
       ]"
-      :enum="[
+      :dataSource="[
         { label: '发请求1', value: 1 },
         { label: '发请求2', value: 2 },
       ]"
     />
     <Field
-      name="[Select]"
+      name="select"
       title="异步选择框"
       :decorator="[FormItem]"
       :component="[
@@ -57,6 +57,7 @@ const form = createForm({
     useAsyncDataSource('select', async (field) => {
       const linkage = field.query('linkage').get('value')
       if (!linkage) return []
+
       return new Promise((resolve) => {
         setTimeout(() => {
           if (linkage === 1) {

diff --git a/packages/element/src/form-layout/style.scss b/packages/element/src/form-layout/style.scss
@@ -0,0 +1,6 @@
+@import '../__builtins__/styles/common.scss';
+
+.#{$formily-prefix}-form-inline {
+  display: flex;
+  flex-wrap: wrap;
+}
diff --git a/packages/element/src/select/index.ts b/packages/element/src/select/index.ts
@@ -7,14 +7,10 @@ import type {
   Option as ElOptionProps,
 } from 'element-ui'
 import { Select as ElSelect, Option as ElOption } from 'element-ui'
-import { resolveComponent, SlotTypes } from '../__builtins__'
+import { resolveComponent } from '../__builtins__'
 
 export type SelectProps = ElSelectProps & {
-  options?: Array<
-    Omit<ElOptionProps, 'label'> & {
-      label: SlotTypes
-    }
-  >
+  options?: Array<ElOptionProps>
 }
 
 const SelectOption = defineComponent<SelectProps>({
@@ -31,10 +27,10 @@ const SelectOption = defineComponent<SelectProps>({
                   if (typeof option === 'string') {
                     return h(
                       ElOption,
-                      { props: { value: option } },
+                      { props: { value: option, label: option } },
                       {
                         default: () => [
-                          resolveComponent(slots?.option ?? option, { option }),
+                          resolveComponent(slots?.option, { option }),
                         ],
                       }
                     )
@@ -44,12 +40,11 @@ const SelectOption = defineComponent<SelectProps>({
                       {
                         props: {
                           ...option,
-                          label: '',
                         },
                       },
                       {
                         default: () => [
-                          resolveComponent(slots?.option ?? option.label, {
+                          resolveComponent(slots?.option, {
                             option,
                           }),
                         ],