Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DefaultBlockExceptionHandler treats all BlockException as FlowException #3443

Open
Linzyoo opened this issue Aug 24, 2024 · 0 comments · May be fixed by #3444
Open

[BUG] DefaultBlockExceptionHandler treats all BlockException as FlowException #3443

Linzyoo opened this issue Aug 24, 2024 · 0 comments · May be fixed by #3444

Comments

@Linzyoo
Copy link
Contributor

Linzyoo commented Aug 24, 2024

Issue Description

Type: bug report

Describe what happened

The DefaultBlockExceptionHandler treat all BlockException as FlowException, even if it is a DegradeException. This is not good.

Describe what you expected to happen

It will set appropriate http status code and message accroding to the type of BlockException.

How to reproduce it (as minimally and precisely as possible)

  1. try to create a degrade exception
  2. it will get 429(too many request) and ”Blocked by Sentinel (flow limiting)"

Tell us your environment

Anything else we need to know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant