Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][C++] Output the error message when access value in Result fail #222

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Aug 15, 2023

Proposed changes

current when access value fail with Result, it just output message like:
error attempting to access value from result containing error.

This change change the behavior that output the message of error it contain.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed issue: #218

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@acezen acezen requested a review from lixueclaire August 15, 2023 04:59
@acezen acezen force-pushed the 218-ouput-error-message branch 2 times, most recently from c6cf7c0 to c726a70 Compare August 15, 2023 06:53
@acezen acezen force-pushed the 218-ouput-error-message branch from c726a70 to 05f96bc Compare August 15, 2023 06:55
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@acezen acezen merged commit c810364 into apache:main Aug 15, 2023
@acezen acezen deleted the 218-ouput-error-message branch August 15, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants