Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jemalloc when building the bundled arrow #122

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

sighingnow
Copy link
Contributor

Proposed changes

We noticed some failure in vineyard in gar loader tests: https://github.com/v6d-io/v6d/actions/runs/4401800380/jobs/7708326106

Not sure why. But disabling jemalloc shouldn't be a big concern and it should be the easiest way for fixing the failure.

image

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

🎊 PR Preview 8f76eb7 has been successfully built and deployed to https://alibaba-graphar-build-pr-122.surge.sh

🤖 By surge-preview

@sighingnow sighingnow force-pushed the ht/disable-arrow-jemalloc branch from 2f99000 to 52f27bd Compare March 14, 2023 07:03
@sighingnow sighingnow merged commit e4dcbfe into apache:main Mar 14, 2023
@sighingnow sighingnow deleted the ht/disable-arrow-jemalloc branch March 14, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant