Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][DevInfra] Reorg the code directory to easily to extend libraries #116

Merged
merged 13 commits into from
Mar 9, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 3, 2023

Proposed changes

Reorganize the code directory and put the C++ library to cpp. The change would make GraphAr easily to extend libraries.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #77

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

🎊 PR Preview fd898aa has been successfully built and deployed to https://alibaba-graphar-build-pr-116.surge.sh

🤖 By surge-preview

@acezen acezen force-pushed the 77-reorg-code-dir branch from 1bd700a to 97992f8 Compare March 8, 2023 02:04
@acezen acezen marked this pull request as ready for review March 8, 2023 02:05
@acezen acezen requested a review from lixueclaire March 8, 2023 02:07
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@acezen acezen merged commit b124402 into apache:main Mar 9, 2023
@acezen acezen deleted the 77-reorg-code-dir branch March 9, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Reorganize the code directory to make developer easily to extend library for other language
2 participants