Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples][Spark] Add examples of integrating with the Neo4j spark connector as an application of GraphAr #107

Merged
merged 16 commits into from
Mar 2, 2023

Conversation

lixueclaire
Copy link
Contributor

@lixueclaire lixueclaire commented Feb 20, 2023

Proposed changes

This change add examples of migrating graph data between Neo4j and GraphAr as a key application of GraphAr. The examples are implemented based on the Neo4j Spark connector and the GraphAr Spark library, including reading graph data from Neo4j to generate GAR files, and reading from GraphAr to create/update instances in Neo4j.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

related to issue #33
add a new data type (Array) to Spark library, related to issue #76

@github-actions
Copy link

github-actions bot commented Feb 20, 2023

🎊 PR Preview 59701e8 has been successfully built and deployed to https://alibaba-graphar-build-pr-107.surge.sh

🤖 By surge-preview

@acezen acezen self-requested a review February 21, 2023 02:40
// read Person vertices from GraphAr and write to Neo4j
def testWriteVerticesToNeo4j(): Unit = {
// read vertex info yaml
val vertex_yaml = getClass.getClassLoader.getResource("gar-test/neo4j/person.vertex.yml").getPath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not find the chunk file of neo4j in gar-test repo. Do we need to put one copy of these file to gar-test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the chunk files are added into gar-test now.

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants