Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move "batch_size" from data to dataloader #475

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Dec 16, 2022

move the key "batch_size" to inside the key "dataloader" in yaml files for xgb, and fix the related bugs

@xieyxclack xieyxclack self-requested a review December 16, 2022 07:42
@xieyxclack xieyxclack added the bug Something isn't working label Dec 16, 2022
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack merged commit f837073 into alibaba:master Dec 20, 2022
@qbc2016 qbc2016 deleted the dev_xgb_dataloader branch December 20, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants