add feature importance to xgb algo #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayrayraykk
previously approved these changes
Nov 18, 2022
| @@ -699,3 +699,6 @@ def update_best_result(self, best_results, new_results, results_type): | |||
| logger.error( | |||
| "cfg.wandb.use=True but not install the wandb package") | |||
| exit() | |||
|
|
|||
| def diagnosis(self, best_results, new_results, results_type): | |||
There was a problem hiding this comment.
The vFL diagnosis requires communication between clients, so we should change diagnosis() here to another name as the function only add a new key to best_results.
rayrayraykk
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing, from the feature_importance dict we can see the number of times that each feature has been used for splitting