Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one bug in federatedscope/gfl/fedsageplus/trainer.py #767

Open
blgpb opened this issue Apr 2, 2024 · 0 comments
Open

one bug in federatedscope/gfl/fedsageplus/trainer.py #767

blgpb opened this issue Apr 2, 2024 · 0 comments

Comments

@blgpb
Copy link

blgpb commented Apr 2, 2024

In the trainer.py,
ctx.y_true = batch.num_missing[mask]
ctx.y_prob = pred_missing

https://github.com/alibaba/FederatedScope/blob/480b67de851df2fa02b7cc2189f1803d947998d7/federatedscope/gfl/fedsageplus/trainer.py#L42C1-L43C34

https://github.com/alibaba/FederatedScope/blob/480b67de851df2fa02b7cc2189f1803d947998d7/federatedscope/gfl/fedsageplus/trainer.py#L66C1-L67C34

It seems that 'pred_missing' (i.e., the output of the missing neighbor generator) and 'num_missing' (i.e., the groundtruth of missing nodes) are used to compute the final result. However, it is a node classification task. We should compute the node classification accuracy.

As a result, I suggest that the node label and the predicted node label should be used to compute the final result.

It may be changed to
ctx.y_true = batch.y[mask]
ctx.y_prob = nc_pred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant