Feat/textarea should support hasClear #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
注意一下代码抽象的原则，textarea和input的共性逻辑抽象到base里，各自独特的实现放到自己的类里即可 |
YSMJ1994
reviewed
Jan 22, 2024
YunMeng99
force-pushed
the
feat/TextArea-hasClear
branch
from
1120ca8
to
6d4800e
Compare
YSMJ1994
requested changes
Jan 24, 2024
YSMJ1994
reviewed
Jan 25, 2024
YSMJ1994
requested changes
Jan 25, 2024
YSMJ1994
approved these changes
Jan 25, 2024
zizairufengLT
added a commit
to zizairufengLT/next
that referenced
this pull request
Mar 15, 2024
chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): upgrade test tools chore(Tree): upgrade test tools chore(Tree): upgrade test tools chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): ts improve chore(Tree): upgrade test tools chore(Tree): ts improve chore(Tree): docs improve chore(Tree): ts improve fix(Tree): expand action area should not shrink when the content is oversize, close alibaba-fusion#4689 (alibaba-fusion#4723) * fix(Tree): [Tree] content whit long text align-right issue, close alibaba-fusion#4689 * chore(Tree): remove unnecessary css specificity close alibaba-fusion#4689 * chore(Tree): ret test code,close alibaba-fusion#4689 * chore(Tree): update test code ,close alibaba-fusion#4689 --------- Co-authored-by: lancely <[email protected]> chore(Animate): fix accidental test error fix(Menu): should update layout when children size changed, close alibaba-fusion#4640 (alibaba-fusion#4722) * fix(Menu): fix menu async load items renderMore issues, close alibaba-fusion#4640 * chore(Menu): update test: menu async load items renderMore issues, close alibaba-fusion#4640 * fix(Menu): update fix menu async load items renderMore issues, close alibaba-fusion#4640 * fix(Menu): update for fix menu async load items renderMore issues, close alibaba-fusion#4640 * fix(Menu): format code for fix menu async load items renderMore issues, close alibaba-fusion#4640 * fix(Menu): format codes for fix menu async load items renderMore issues, close alibaba-fusion#4640 --------- Co-authored-by: lancely <[email protected]> chore(Box): rename to ts refactor(Box): convert to TypeScript, impove docs and tests feat(Input): TextArea support hasClear, close alibaba-fusion#4334 (alibaba-fusion#4714) * feat(Input): textarea support hasClear, close alibaba-fusion#4334 * feat(Input): textarea code optimization , close alibaba-fusion#4334 * feat(Input): modify the class name of the clear button close alibaba-fusion#4334 * feat(Input): Internationalization --------- Co-authored-by: WB01081293 <[email protected]> chore(Search): rename to ts refactor(Search): convert to TypeScript, impove docs and tests feat(Search): restore code logic chore(BuildTool): remove node-sass in deep dependencies fix(Rating): fix grade background, close alibaba-fusion#4734 (alibaba-fusion#4735) Co-authored-by: chenkeyao.chenkeya <[email protected]> docs(*): Generate docs from tsdoc chore(*): Release-1.27.3 fix(Util): compatibility breaking introduced by Object.hasOwn chore(*): apply assignSubComponent util chore(*): Release-1.27.4 chore(BuildTool): sync together refactor(Grid): convert to TypeScript, impove docs and tests refactor(Grid): impove docs and types refactor(Grid): improve typescript refactor(Grid): rename to ts refactor(Grid): improve typescript chore(List): rename files to ts refactor(List): convert to TypeScript, impove docs and tests refactor(List): improve docs refactor(List): improve docs test(Animate): add log for debugging accidental failed expand test case chore(Validate): rename to ts refactor(Validate): convert to TypeScript, improve tests test(Validate): improve for pr comments chore(BuildTool): move index.html to serve dir chore(BuildTool): improve jsx adjustment fix(TimePicker2): should has focus style when visible, close alibaba-fusion#4657 (alibaba-fusion#4738) * fix(TimePicker2): TimePicker2 focusing issue noborder, close alibaba-fusion#4657 * fix(TimePicker2): Update test TimePicker2 focusing issue noborder, close alibaba-fusion#4657 --------- Co-authored-by: lancely <[email protected]> refactor(Cascader): rename filename to ts refactor(Cascader): ts improve refactor(Cascader): doc improve refactor(Cascader): test improve refactor(Cascader): fix comments issue fix(ConfigProvider): improve config types, close alibaba-fusion#4751 chore(*): export scoped type for make compiled types simply chore(ConfigProvider): improve for codereview fix(Overlay): shouldUpdatePosition when status is mounting or none, close alibaba-fusion#4740 chore(*): Release-1.27.5-beta.0 fix(Overlay): solve problems caused by numerical floating, close alibaba-fusion#4740 chore(*): Release-1.27.5-beta.1 fix(*): rollback alibaba-fusion#4746 and fix textarea clear spec chore(*): Release-1.27.5 Update stale.yml chore(BuildTool): 支持指定主题包调试`run start --theme xxx` chore(DatePicker): fix theme demo margin, close alibaba-fusion#3627 chore(Tree): upgrade test tools chore(Tree): ts improve
eternalsky
pushed a commit
that referenced
this pull request
Jul 16, 2024
* feat(Input): textarea support hasClear, close #4334 * feat(Input): textarea code optimization , close #4334 * feat(Input): modify the class name of the clear button close #4334 * feat(Input): Internationalization --------- Co-authored-by: WB01081293 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.