feat(Dialog): new api noPadding for Dialog body padding fix #3892 #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/1.26 #3893 +/- ##
===========================================
Coverage 90.40% 90.40%
===========================================
Files 305 305
Lines 17899 17899
Branches 5394 5507 +113
===========================================
Hits 16182 16182
Misses 1696 1696
Partials 21 21
Continue to review full report at Codecov.
|
lakerswgq
reviewed
May 18, 2022
src/drawer/drawer-v2.jsx
Outdated
| @@ -272,6 +272,11 @@ const Drawer = props => { | |||
| setVisibleOverlayToParent(id, node); | |||
| }; | |||
|
|
|||
| const nstyle = { | |||
| ...{ width, height }, | |||
lakerswgq
reviewed
May 18, 2022
| @@ -68,6 +68,7 @@ API变化： | |||
| | isFullScreen | [v2废弃] 是否撑开页面。 v2 改用 overflowScroll | Boolean | false | | | |||
| | shouldUpdatePosition | [v2废弃] 是否在对话框重新渲染时及时更新对话框位置，一般用于对话框高度变化后依然能保证原来的对齐方式 | Boolean | false | | | |||
| | minMargin | [v2废弃] 对话框距离浏览器顶部和底部的最小间距，align 被设置为 'cc cc' 并且 isFullScreen 被设置为 true 时不生效 | Number | 40 | | | |||
| | noPadding | 去除body内间距 | Boolean | - | 1.26 | | |||
|
|
|||
lakerswgq
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.