Dialog margin no footer #3809
Dialog margin no footer #3809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3809 +/- ##
==========================================
- Coverage 90.59% 90.56% -0.03%
==========================================
Files 303 303
Lines 17819 17835 +16
Branches 5369 5375 +6
==========================================
+ Hits 16143 16153 +10
- Misses 1657 1662 +5
- Partials 19 20 +1
Continue to review full report at Codecov.
|
|
docs/dialog/theme/index.jsx 里面增加一个 footer 显示隐藏控制项，默认为显示 |
| } | ||
|
|
||
| &-body-no-footer { | ||
| margin-bottom: $dialog-content-margin-bottom-no-footer; |
There was a problem hiding this comment.
这个样式感觉可以删掉，下面 {$dialog-prefix}-header + #{$dialog-prefix}-body-no-footer 才展示 margin-bottom
There was a problem hiding this comment.
这样就只支持 v2 了，旧弹窗不支持了
There was a problem hiding this comment.
-
这一行是重复样式，没有 footer 的时候会在 body 上设置 margin-bottom。
-
下面是有 header + no-footer {} 是有 header 的时候才设置 margin-bottom。
如果你一直想加上留1，如果只有header存在的时候才加留2。我建议是留2删1
src/dialog/main.scss
Outdated
| @@ -6,6 +6,8 @@ | |||
| @include box-sizing; | |||
| position: fixed; | |||
| z-index: 1001; | |||
| display: flex; | |||
| flex-direction: column; | |||
There was a problem hiding this comment.
在body 上面用了 margin 就不需要 flex 布局了吧，感觉可以去掉这两行
src/dialog/main.scss
Outdated
| @@ -28,6 +30,11 @@ | |||
| font-size: $dialog-content-font-size; | |||
| line-height: $font-lineheight-2; | |||
| color: $dialog-content-color; | |||
| flex: 1 1 auto; | |||
Fix #3799