fix(Field): getValues return initValue- #close 792 #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdkahn
commented
Jun 20, 2019
jdkahn
commented
- if getValues is called before init, should return initValue
- getIn, setIn unit tests
Codecov Report
@@ Coverage Diff @@
## feat/1.16.0 #807 +/- ##
===============================================
- Coverage 91.28% 84.72% -6.56%
===============================================
Files 244 244
Lines 14021 11287 -2734
Branches 4403 2806 -1597
===============================================
- Hits 12799 9563 -3236
+ Misses 1203 917 -286
- Partials 19 807 +788
Continue to review full report at Codecov.
|
jdkahn
changed the title
bindoon
reviewed
Jun 20, 2019
src/field/index.js
Outdated
| allValues = setIn(allValues, f, this.getValue(f)); | ||
| } | ||
| }); | ||
| } else if (this.initValue) { |
There was a problem hiding this comment.
we can not do this, because people use reset or remove to clear all value.
and he expect to get {}, but return initValue.
|
hold for this PR, we need do big change to Field to make it use more friendly. |
- if getValues is called before init, should return initValue - getIn, setIn unit tests
- getValues should not return disabled field values
|
we should also update values while onChange trigged. |
- field.values is the new source of truth - field.fieldsMeta is for initialized components - disabled field support was broken, removed support
bindoon
reviewed
Jun 27, 2019
| @@ -361,11 +375,21 @@ class Field { | |||
| this.setValue(name, fieldsValue[name], false); | |||
| }); | |||
| } else { | |||
| // NOTE: this is a shallow merge | |||
There was a problem hiding this comment.
add NOTE:
we have two values a.b.c=1 ; a.b.d=2, and use setValues({a:{b:{c:3}}}) , then because of shallow merge a.b.d will lost, we will get only {a:{b:{c:3}}}
bindoon
approved these changes
Jun 27, 2019
jdkahn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.