Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): onSearch run only once close #4049 #4524

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

YunMeng99
Copy link
Contributor

No description provided.

Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仔细看一下issue中的问题,用户是设置了 autoHighlightFirstItem=false 后出现的两次search问题, https://github.com/alibaba-fusion/next/issues/4049#issuecomment-1245048667,你这里简单粗暴把change中的onSearch去掉了,完全跟用户的问题无关呀

@YSMJ1994 YSMJ1994 self-requested a review November 15, 2023 13:06
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcd19d7) 90.75% compared to head (c90401c) 11.23%.

❗ Current head c90401c differs from pull request most recent head 659ba46. Consider uploading reports for the commit 659ba46 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4524       +/-   ##
===========================================
- Coverage   90.75%   11.23%   -79.53%     
===========================================
  Files         305      305               
  Lines       17903    17903               
  Branches     5289     5289               
===========================================
- Hits        16248     2011    -14237     
- Misses       1638    15888    +14250     
+ Partials       17        4       -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YSMJ1994 YSMJ1994 merged commit 1eea155 into master Nov 15, 2023
18 of 19 checks passed
@YSMJ1994 YSMJ1994 deleted the fix/Search-onChange-calls branch November 15, 2023 13:40
@YSMJ1994 YSMJ1994 restored the fix/Search-onChange-calls branch November 15, 2023 13:53
YSMJ1994 added a commit that referenced this pull request Nov 15, 2023
…hlightFirstItem=false, close #4049 (#4524)"

This reverts commit 1eea155.
@YSMJ1994 YSMJ1994 deleted the fix/Search-onChange-calls branch November 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search]回车提交如果已在dataSource里为什么会触发两次onSearch
2 participants