Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Overlay): React does not recognize the prop on a DOM element #4277

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

jun599
Copy link
Contributor

@jun599 jun599 commented Mar 7, 2023

close #3812

@jun599 jun599 requested a review from lakerswgq March 7, 2023 07:00
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (9e69eab) 90.58% compared to head (0611c00) 90.58%.

❗ Current head 0611c00 differs from pull request most recent head 0839e9c. Consider uploading reports for the commit 0839e9c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4277      +/-   ##
==========================================
- Coverage   90.58%   90.58%   -0.01%     
==========================================
  Files         305      305              
  Lines       17948    17950       +2     
  Branches     5525     5526       +1     
==========================================
+ Hits        16259    16260       +1     
- Misses       1668     1669       +1     
  Partials       21       21              
Impacted Files Coverage Δ
src/overlay/index.jsx 75.00% <50.00%> (-1.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lakerswgq lakerswgq merged commit 8131740 into master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Overlay]全局配置Popup.v2会提示React does not recognize the shouldUpdatePosition prop on a DOM element
2 participants