Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form.Item): priority of properties #4088

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

siyou
Copy link
Contributor

@siyou siyou commented Sep 2, 2022

The useLabelForErrorMessage of FormItem should have a higher priority.

The useLabelForErrorMessage of FormItem should have a higher priority.
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Base: 90.56% // Head: 90.56% // No change to project coverage 👍

Coverage data is based on head (141b5b7) compared to base (64777e1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4088   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files         306      306           
  Lines       17942    17942           
  Branches     5407     5407           
=======================================
  Hits        16249    16249           
  Misses       1672     1672           
  Partials       21       21           
Impacted Files Coverage Δ
src/form/item.jsx 94.95% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lakerswgq lakerswgq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

太强了,还补充了单测

@lakerswgq lakerswgq merged commit b0aec62 into alibaba-fusion:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants