fix(Tab): calculate use wrapper width instead of navbar width #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
==========================================
- Coverage 90.05% 90.03% -0.02%
==========================================
Files 270 270
Lines 15185 15190 +5
Branches 4917 4922 +5
==========================================
+ Hits 13675 13677 +2
- Misses 1484 1487 +3
Partials 26 26
Continue to review full report at Codecov.
|
youluna
reviewed
Nov 27, 2019
src/tab/tabs/nav.jsx
Outdated
| @@ -522,10 +522,6 @@ class Nav extends React.Component { | |||
| this.wrapper = ref; | |||
| }; | |||
|
|
|||
| navbarRefHandler = ref => { | |||
| this.navbar = ref; | |||
There was a problem hiding this comment.
- 删ref有一定的风险，可能用户会取到instance然后用到this.navbar，建议保留
- 另外如果是为了解决extra跟超出模式下的左右箭头位置冲突问题，那么找一下设计师给一个官方的支持吧
youluna
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.