Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat date picker #1284

Merged
merged 12 commits into from
Nov 20, 2019
Merged

Conversation

myronliu347
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1284 into feat/1.19.0 will decrease coverage by 0.15%.
The diff coverage is 91.24%.

Impacted file tree graph

@@              Coverage Diff               @@
##           feat/1.19.0   #1284      +/-   ##
==============================================
- Coverage        90.66%   90.5%   -0.16%     
==============================================
  Files              264     266       +2     
  Lines            14744   14914     +170     
  Branches          4761    4833      +72     
==============================================
+ Hits             13367   13498     +131     
- Misses            1350    1390      +40     
+ Partials            27      26       -1
Impacted Files Coverage Δ
src/calendar/index.jsx 100% <100%> (ø)
src/date-picker/index.jsx 100% <100%> (ø) ⬆️
src/date-picker/util/index.js 95.55% <66.66%> (-1.04%) ⬇️
src/date-picker/range-picker.jsx 91.71% <77.41%> (-1.5%) ⬇️
src/date-picker/week-picker.jsx 96.03% <96.03%> (ø)
src/select/base.jsx 84% <0%> (-6.28%) ⬇️
src/upload/upload.jsx 79.24% <0%> (-3%) ⬇️
src/upload/list.jsx 73.44% <0%> (-2.61%) ⬇️
src/number-picker/number-picker.jsx 94.41% <0%> (-1.42%) ⬇️
src/input/input.jsx 93.75% <0%> (-0.94%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce426c...7c3fe27. Read the comment docs.

Copy link
Member

@youluna youluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 没有使用type更换RangePicker面板的demo,至少得加个demo
    2.中文模式下感觉用 2019-44周 更合适,而不是全都用英文
    3.文档里写一下WeekPicker是1.19.0+ 才有的

src/locale/en-us.js Outdated Show resolved Hide resolved
src/date-picker/util/index.js Show resolved Hide resolved
src/date-picker/range-picker.jsx Show resolved Hide resolved
src/date-picker/scss/date-picker.scss Show resolved Hide resolved
src/date-picker/week-picker.jsx Show resolved Hide resolved
@myronliu347
Copy link
Member Author

  1. 没有使用type更换RangePicker面板的demo,至少得加个demo
    2.中文模式下感觉用 2019-44周 更合适,而不是全都用英文
    3.文档里写一下WeekPicker是1.19.0+ 才有的
  1. Demo 已加
  2. 这个根据moment语言包决定
  3. version 加上了

@youluna youluna merged commit 42de085 into alibaba-fusion:feat/1.19.0 Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants