fix(Table): prevent crash when dataSource is undefined, close #4073

package.json

@@ -110,7 +110,6 @@
     "react-lifecycles-compat": "^3.0.4",
     "react-transition-group": "^2.2.1",
     "resize-observer-polyfill": "^1.5.1",
-    "semver": "^7.3.5",
     "shallow-element-equals": "^1.0.1"
   },
   "devDependencies": {
@@ -243,7 +242,8 @@
     "urllib": "^2.36.1",
     "webpack": "^3.0.0",
     "webpack-dev-server": "^2.x",
-    "whatwg-fetch": "^2.0.3"
+    "whatwg-fetch": "^2.0.3",
+    "semver": "^7.3.5"
   },
   "peerDependencies": {
     "@alifd/meet-react": "^2.0.0",

src/table/base.jsx

@@ -829,21 +829,21 @@ class Table extends React.Component {
             others.dir = 'rtl';
         }
 
-        const loadingcls = classnames({
-            [`${prefix}table-loading-content`]: true,
-        });
-
-        return (
+        const content = (
             <div
                 className={cls}
                 style={style}
                 ref={ref || this.getTableEl}
                 {...obj.pickOthers(Object.keys(Table.propTypes), others)}
             >
                 {table}
-                {loading ? <Loading className={loadingcls} /> : null}
             </div>
         );
+        if (loading) {
+            const loadingClassName = `${prefix}table-loading`;
+            return <LoadingComponent className={loadingClassName}>{content}</LoadingComponent>;
+        }
+        return content;
     }
 }
 

src/table/index.jsx

@@ -1,5 +1,5 @@
 import ConfigProvider from '../config-provider';
-import Base from './base-pre';
+import Base from './base';
 import tree from './tree';
 import fixed from './fixed';
 import selection from './selection';

test/table/issue-spec.js

@@ -1267,4 +1267,17 @@ describe('Issue', () => {
 
         assert(container.querySelectorAll('.my-table').length >= 1);
     })
+
+    it('should not crash when dataSource is undefined, close #4073', () => {
+        const container = document.createElement('div');
+        document.body.appendChild(container);
+
+        ReactDOM.render(<Table >
+            <Table.Column title="Id" lock htmlTitle="Unique Id" dataIndex="id"/>
+            <Table.Column title="Title" dataIndex="title.name" />
+            <Table.Column title="Time" dataIndex="time"/>
+        </Table>, container);
+
+        assert(container.querySelector('.next-table-empty'))
+    })
 });