fix(Input): bug of value=0 with htmlType=number

alibaba-fusion · Nov 23, 2018 · 0805a38 · 0805a38
1 parent 5d5a497
commit 0805a38
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/input/base.jsx b/src/input/base.jsx
@@ -137,7 +137,8 @@ class Base extends React.Component {
             });
         }
 
-        if (this.props.htmlType === 'number') {
+        // Number('') = 0
+        if (value && this.props.htmlType === 'number') {
             value = Number(value);
         }
 

diff --git a/test/input/index-spec.js b/test/input/index-spec.js
@@ -171,27 +171,33 @@ describe('input', () => {
                     return (
                         <Input ref='input' onFocus={(e) => {
                             assert(this.refs.input.getInstance().getInputNode() !== undefined)
+                            done();
                         }}/>
                     );
                 }
             }
             let wrapper = mount(<App/>);
 
             wrapper.find('input').simulate('focus');
-
-            done();
         });
 
         it('should support htmlType=number', (done) => {
             let onChange = (value) => {
                 assert(value === 20);
+                done();
             }, wrapper = mount(<Input defaultValue="abcdef" htmlType="number" onChange={onChange}/>);
 
             wrapper.find('input').simulate('change', {target: {value: '20'}});
-
-            done();
         });
 
+        it('should support htmlType=number value="" ', (done) => {
+            let onChange = (value) => {
+                assert(value === '');
+                done();
+            }, wrapper = mount(<Input defaultValue="abcdef" htmlType="number" onChange={onChange}/>);
+
+            wrapper.find('input').simulate('change', {target: {value: ''}});
+        });
     });
     describe('react api', () => {
         it('calls componentWillReceiveProps', (done) => {