feat: add test for uncovered lines

persian-tools · Sep 18, 2020 · 70f0577 · 70f0577
1 parent 3768ed1
commit 70f0577
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/src/modules/bill.ts b/src/modules/bill.ts
@@ -35,9 +35,10 @@ interface IBillData {
 }
 
 interface Params {
-	billId: number | string;
-	paymentId: number | string;
+	billId?: number | string;
+	paymentId?: number | string;
 	currency?: Currency;
+	barcode?: string;
 }
 
 class Bill {
@@ -47,8 +48,8 @@ class Bill {
 	billId: string;
 	billPayment: string;
 
-	constructor({ billId, paymentId, currency }: Params) {
-		this.barcode = null;
+	constructor({ billId, paymentId, currency, barcode }: Params) {
+		this.barcode = barcode || null;
 		this.currency = currency || "toman";
 		this.billId = "";
 		this.billPayment = "";
@@ -99,7 +100,7 @@ class Bill {
 	public findByBarcode(): void {
 		if (this.barcode) {
 			this.billId = this.barcode.substr(0, 13);
-			this.billPayment = this.barcode.split(this.billId)[1];
+			this.billPayment = this.barcode.substr(16, 10);
 		}
 	}
 

diff --git a/test/bill.spec.ts b/test/bill.spec.ts
@@ -46,6 +46,7 @@ describe("bill", () => {
 		expect(
 			new Bill({ billId: 7748317800142, paymentId: 1770160, currency: "rial" }).getData().isValidBillPayment,
 		).toEqual(true);
+		expect(new Bill({ billId: 7748317800142, currency: "rial" }).getData().isValidBillPayment).toEqual(false);
 		expect(
 			new Bill({ billId: 9174639504124, paymentId: 12908197, currency: "rial" }).getData().isValidBillPayment,
 		).toEqual(false);
@@ -86,4 +87,17 @@ describe("bill", () => {
 			"22343223446130001070189",
 		);
 	});
+
+	it("getBarcode", () => {
+		const newBill = new Bill({});
+		newBill.setBarcode("22343223446130001070189");
+		expect(newBill.barcode).toEqual("22343223446130001070189");
+	});
+
+	it("findByBarcode", () => {
+		const newBill = new Bill({ barcode: "22343223446130001070189" });
+		newBill.findByBarcode();
+		expect(newBill.billId).toEqual("2234322344613");
+		expect(newBill.billPayment).toEqual("1070189");
+	});
 });