Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect typing on MultisigTransactionSigner #433

Closed
barnjamin opened this issue Jan 12, 2023 · 1 comment
Closed

Incorrect typing on MultisigTransactionSigner #433

barnjamin opened this issue Jan 12, 2023 · 1 comment
Assignees
@bbroder-algo
Labels
new-bug Bug report that needs triage

Comments

@barnjamin
Copy link
Contributor

Subject of the issue

https://github.com/algorand/py-algorand-sdk/blob/master/algosdk/atomic_transaction_composer.py#L682

The type hint for the sks is str but should be list[str] or List[str] for pre py3.10
@barnjamin barnjamin added the new-bug Bug report that needs triage label Jan 12, 2023
@barnjamin barnjamin mentioned this issue Jan 12, 2023
Merged
@bbroder-algo
Copy link
Contributor

agreed

@bbroder-algo bbroder-algo self-assigned this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbroder-algo bbroder-algo

Labels
new-bug Bug report that needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barnjamin @bbroder-algo