Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Does not work with vue 2.4.x #186

Closed
michaelchiche opened this issue Jul 17, 2017 · 4 comments
Closed

Does not work with vue 2.4.x #186

michaelchiche opened this issue Jul 17, 2017 · 4 comments

Comments

@michaelchiche
Copy link

Do you want to request a feature or report a bug?
I report a bug.

As in the link shown: https://codepen.io/anon/pen/KqLMXY#anon-login

Bug: What is the current behavior?
There is an exception which breaks the whole app

Bug: What is the expected behavior?
It should work fine

Bug: What browsers are impacted? Which versions?
Tested on latest versions of chrome, safari & firefox

Bug: What is the proposed solution?
Lock on 2.3.x for now or upgrade code ?

From what I can understand, it looks like the DI does not work properly with this upgrade

What is the version you are using? Always use the latest one before opening a bug issue.
I did a fresh npm install following the guide here: vue-instantsearch.netlify.com

@Haroenv
Copy link
Contributor

Haroenv commented Jul 18, 2017

Hey @michaelchiche, we found out about this change yesterday as well, the problem is indeed that the dependency injection -- the context -- changed from Vue 2.3 to 2.4. We didn't find an immediate solution to this, but definitely will keep an eye on this and have it fixed asap. For now you can still use 2.3.X indeed

see also vuejs/vue#6093

@Haroenv
Copy link
Contributor

Haroenv commented Jul 18, 2017

A workaround mentioned in that thread is to do this after your import of Vue and before your import of Vue InstantSearch:

Vue.config.optionMergeStrategies.inject = (parent, child) => Vue.util.extend(Vue.util.extend({}, parent), child)

@rayrutjes
Copy link
Member

A fix has been merged. Now waiting for release of 2.4.2 🎉

@rayrutjes
Copy link
Member

@michaelchiche should now be fixed in 2.4.2 of Vue.js
Please re-open the issue if the new release does not solve your initial problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants