Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): add fetch-depth and git fetch #778

Merged

Conversation

tyankatsu0105
Copy link
Contributor

What

fix #777

Add fetch-depth: 0 and git fetch to github getBaseConfig.

@tyankatsu0105
Copy link
Contributor Author

@jeetiss
How about this PR?

@eunjae-lee
Copy link
Contributor

Thank you both @tyankatsu0105 and @jeetiss !
I have a question. We didn't have this option before but why was it working before and not any more?
Has GitHub Actions changed?
Or @tyankatsu0105 's repo or setting is related?

@tyankatsu0105
Copy link
Contributor Author

@eunjae-lee
Exactly. I don't know about GitHub Actions very much.
I think we need a repository to reproduce this problem.🤔

@tyankatsu0105
Copy link
Contributor Author

@eunjae-lee
There is an same error at this actions.
https://github.com/tyankatsu0105/eslint-with-typescript/runs/628194075?check_suite_focus=true

@jeetiss
I think you know about GitHub Actions very much.
Do you know why there is an error?

@eunjae-lee
Copy link
Contributor

@tyankatsu0105 I guess the change in this PR makes sense.
Does the change also fix the issue in eslint-with-typescript package?

@tyankatsu0105
Copy link
Contributor Author

@eunjae-lee
Yes.
Now I add git fetch and fetch-depth: 0.
It looks like working correctly.
https://github.com/tyankatsu0105/eslint-plugin/runs/629421080?check_suite_focus=true

@jeetiss
Copy link
Contributor

jeetiss commented Apr 29, 2020

Hello @eunjae-lee and @tyankatsu0105

We didn't have this option before but why was it working before and not any more?
Has GitHub Actions changed?

No, GHA has not changed, it didn't work because I did not test this staff)

But, now everything is okey. Kudos to @tyankatsu0105

@eunjae-lee
Copy link
Contributor

Oh, then this must be not tested with toReleaseBranch strategy.
Thanks @tyankatsu0105 and @jeetiss 😁

@eunjae-lee eunjae-lee changed the title feat(actions): add fetch-depth and git fetch fix(actions): add fetch-depth and git fetch Apr 29, 2020
@eunjae-lee eunjae-lee merged commit 994e4ff into algolia:master Apr 29, 2020
@tyankatsu0105 tyankatsu0105 deleted the feat/consider-difference-base-release branch April 30, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pathspec 'develop' did not match any file(s) known to git
3 participants