Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up all cases for releaseType #631

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 22, 2020

closes #594.

This PR fixes getReleaseType.

normal cases

  • 1.2.3 -> 2.0.0: major
  • 1.2.3 -> 1.3.0: minor
  • 1.2.3 -> 1.2.4: patch

next version has a tag

  • 1.2.3 -> 1.2.4-alpha.0: prerelease
  • 1.2.4-alpha.0 -> 1.2.4-alpha.1: prerelease

version with a tag -> version without one

  • 1.2.4-alpha.0 -> 1.2.4: patch
  • 1.2.4-alpha.0 -> 1.2.5: patch
  • 1.2.4-alpha.0 -> 1.3.0: minor
  • 1.2.4-alpha.0 -> 2.0.0: major
  • 1.3.0-alpha.0 -> 1.3.0: minor
    Just like normal cases, the new version decides the releaseType.

@eunjae-lee eunjae-lee merged commit 89e5d73 into master Jan 22, 2020
@eunjae-lee eunjae-lee deleted the fix/release-type branch January 22, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine releaseType
1 participant