fix: replace GH_TOKEN with GITHUB_TOKEN #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that provided by default
eunjae-lee
changed the title
|
No worries! Thanks for the research and the test 🙂 |
eunjae-lee
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realize that we don't need
GH_TOKENfor releases. I found librarychangesetsand they create releases with github bot 👉🏻https://github.com/atlassian/changesets/releasesI think that GITHUB_TOKEN don't provide enough rights for all todos and because of that
shipjs triggerfails https://github.com/jeetiss/try-shipjs/runs/330554677#step:6:54 , but problem was in different thingI test GITHUB_TOKEN and every works fine now (see last release) https://github.com/jeetiss/try-shipjs/releases so I replace all tokens to GITHUB_TOKEN and change github actions guide
Sorry about that :)