fix: rename monorepo.readVersionFrom to monorepo.mainVersionFile (#350)

algolia · Oct 20, 2019 · 107255a · 107255a
1 parent a06660d
commit 107255a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/GUIDE.md b/GUIDE.md
@@ -230,7 +230,7 @@ Ship.js currently supports monorepo project(Independent versioning is not suppor
 ```js
 module.exports = {
   monorepo: {
-    readVersionFrom: "package.json", // or `lerna.json`, or whatever a json file you can read the latest `version` from.
+    mainVersionFile: "package.json", // or `lerna.json`, or whatever a json file you can read the latest `version` from.
     packagesToBump: ["packages/*", "examples/*"],
     packagesToPublish: ["packages/*"]
   }

diff --git a/packages/shipjs-lib/src/lib/config/defaultConfig.js b/packages/shipjs-lib/src/lib/config/defaultConfig.js
@@ -3,7 +3,7 @@ import shipJsVersion from '../../version';
 export default {
   remote: 'origin',
   // monorepo: {
-  //   readVersionFrom: 'package.json',
+  //   mainVersionFile: 'package.json',
   //   packagesToBump: ['packages/*', 'examples/*'],
   //   packagesToPublish: ['packages/*'],
   // },

diff --git a/packages/shipjs/src/step/prepare/validate.js b/packages/shipjs/src/step/prepare/validate.js
@@ -28,8 +28,8 @@ export default ({ config, dir }) =>
       const { mergeStrategy, monorepo, getTagName } = config;
       const baseBranches = getBaseBranches({ mergeStrategy });
       const currentVersion =
-        monorepo && monorepo.readVersionFrom
-          ? getCurrentVersion(dir, monorepo.readVersionFrom)
+        monorepo && monorepo.mainVersionFile
+          ? getCurrentVersion(dir, monorepo.mainVersionFile)
           : getCurrentVersion(dir);
       const currentTagName = getTagName({ version: currentVersion });
       const result = validateBeforePrepare({

diff --git a/ship.config.js b/ship.config.js
@@ -3,7 +3,7 @@ const path = require("path");
 
 module.exports = {
   monorepo: {
-    readVersionFrom: "package.json",
+    mainVersionFile: "package.json",
     packagesToBump: ["packages/*"],
     packagesToPublish: ["packages/*"]
   },