Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep key in child elements, fixes #301 #841

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: keep key in child elements, fixes #301 #841

wants to merge 2 commits into from

Conversation

DanielHara
Copy link

@DanielHara DanielHara commented Jan 30, 2024 •
edited
Loading

@armandabric

Fixes #301, test case was added

It's my first contribution, so just let me know if everything is ok according to the guidelines of the project (I didn't find a CONTRIBUTING file), and I'll change the PR accordingly.

Thank you very much! 🚀

@DanielHara DanielHara mentioned this pull request Jan 30, 2024
Open
@DanielHara DanielHara changed the title fix key in child elements fix: keep key in child elements, fixes #301 Jan 30, 2024
@DanielHara
Copy link
Author

@armandabric , any feedback on merging this? :)

@DanielHara
Copy link
Author

@armandabric , any feedback on merging this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Children's key is missing
1 participant
@DanielHara