This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
feat(templates): Add Android template #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLNech
approved these changes
Jul 4, 2018
There was a problem hiding this comment.
@francoischalifour lovely ❤️
more useful info to log
I think that's as good as it can get, as you output the location just before :)
unnecessary files
test/java/com/algolia/instantsearch/app/ExampleUnitTest.java: you can remove the wholetestfolderandroidTest/java/com/algolia/instantsearch/app/ExampleInstrumentedTest.java: same, you can removeandroidTestdrawable/product_placeholder.png: unused
Note that I decided to name the package com.algolia.instantsearch.app
I would avoid com.algolia as it won't always be used by Algolia employees. To err on the side of safety, I would use instead com.example.instantsearch.app and let the user update if relevant
Approving as these changes are not blockers, I trust you to apply those before merging :)
|
Thank you @PLNech 🙌 |
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the InstantSearch Android template to the CLI.
Preview
CLI
Generated app
How to review
As opposed to other templates (web and iOS), there's no install task since Android Studio manages dependencies installation. The only task is the teardown which explains how to open the project (cc @PLNech if there's more useful info to log).
Please review the folder
src/templates/InstantSearch Androidto check if there are unnecessary files. You can ignore the snapshot files (they are used to avoid regression over time). Note that I decided to name the packagecom.algolia.instantsearch.app, which might not be the best.