This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix(cli): use latest version when stable unavailable #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Jun 15, 2018
francoischalifour
approved these changes
Jun 15, 2018
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we provide a template directly from the CLI we don't let the user choose the version. By default we pick the latest
stableversion available. When there is nostableavailable Yarn will ask for which version you want to install but the template is generated with an empty version.This PR fix this issue by taking the latest version available in case the latest
stableis not available. I also added the foldersampleto the.gitignoreto test the CLI with this folder name. We can test the template generation without pollute the git diff.Before:
{ "dependencies": { "react-instantsearch-native": "^" } }After:
{ "dependencies": { "react-instantsearch-native": "^5.2.0-beta.1" } }