This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
feat: check for compatibility with current LTS versions of node #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: compatibility with versions that are EOL (up to 12) is not guaranteed
Haroenv
approved these changes
May 17, 2022
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…lia/create-instantsearch-app#569) * feat: check for compatibility with current LTS versions of node BREAKING CHANGE: compatibility with versions that are EOL (up to 12) is not guaranteed * remove terminal colors from unit test snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the versions of node against which we test our templates for compatibility.
Currently we test for node 10 and 12, but they are both EOL. This creates issues with some of our transitive dependencies that don't support them anymore and would break our testing process.
Instead of fighting an ultimately endless battle against those by pinning their versions, this PR moves forward by testing compatibility with current LTS versions (14 and 16).
This can be considered a breaking change even though it doesn't change the build, as we currently don't have any support/deprecation policy for this project.
Additional changes
now(.sh) is replaced withvercel