This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix(js): update and simplify dependencies #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #566 through simplification of the dependencies (no longer deasync, which was apparently problematic in some cases, i couldn't reproduce)
Haroenv
requested review from
a team,
dhayab and
FabienMotte
and removed request for
a team
sarahdayan
reviewed
May 16, 2022
There was a problem hiding this comment.
@Haroenv Other than the dependency simplifications in package.json, what are the other changes about? They don't seem related, are they?
|
@sarahdayan panel indeed isn't related, that's right, it was just something I found annoying and can do in a separate PR. The manifest etc. helps with the simplification |
|
Yes, let's split the panel changes. |
dhayab
reviewed
May 17, 2022
dhayab
approved these changes
May 17, 2022
FabienMotte
approved these changes
May 17, 2022
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…ch-app#567) * fix(js): update and simplify dependencies fixes algolia/create-instantsearch-app#566 through simplification of the dependencies (no longer deasync, which was apparently problematic in some cases, i couldn't reproduce) * update snapshots * remove wrong entry point * remove node 10 * undo coolness * panle * upd * upd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #566 through simplification of the dependencies (no longer deasync, which was apparently problematic in some cases, i couldn't reproduce)