This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
feat(vue): add vue3 + vite template #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
requested review from
a team,
FabienMotte and
Haroenv
and removed request for
a team
Haroenv
reviewed
Feb 11, 2022
| const install = require('../../tasks/node/install'); | ||
| const teardown = require('../../tasks/node/teardown'); | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
maybe instead of "with vite", it should lead with "with vue 3", what do you think?
There was a problem hiding this comment.
It's okay with me, I was not sure how opinionated we could be by chosing Vite over other tools.
There was a problem hiding this comment.
We're opinionated in the tools for the other examples too, so I don't think this really has an impact. As long as it works on codesandbox easily, any tool is fine
Haroenv
approved these changes
Feb 11, 2022
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with an upcoming guide on integrating autocomplete within a vue-instantsearch app, I thought it would be interesting to have a ready to use boilerplate for a vue instantsearch with vue 3.
I opted to use Vite instead of vue cli, but I can switch back if there is an issue I am not aware of.