This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix(angular): move styles import to angular.json #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the snapshots still need to be updated @dhayab, but this looks promising! |
Haroenv
reviewed
Oct 19, 2021
dhayab
force-pushed
the
fix/531
branch
2 times, most recently
from
1af8ba9
to
ee5d3a3
Compare
dhayab
requested review from
a team,
tkrugg and
francoischalifour
and removed request for
a team
tkrugg
approved these changes
Oct 20, 2021
Haroenv
approved these changes
Oct 21, 2021
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…antsearch-app#532) * fix(angular): move styles import to angular.json * test(angular): update template snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Angular template, importing styles located in node_modules using
@importdo not work in Codesandbox environments. To work around this, I moved the imports to angular.json where it is handled correctly.I also added basic styling to remove margin/padding on html and set a sans-serif font.
This should close #531.