This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
feat(js): add typescript to the js template #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on the (for now) not exported as TS https://github.com/algolia/instantsearch.js/blob/master/src/index.ts
Haroenv
requested review from
a team,
eunjae-lee and
francoischalifour
and removed request for
a team
eunjae-lee
previously approved these changes
Aug 23, 2021
Haroenv
commented
Aug 23, 2021
Haroenv
commented
Aug 23, 2021
Haroenv
commented
Aug 23, 2021
francoischalifour
approved these changes
Aug 24, 2021
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…arch-app#464) * feat(js): add typescript to the js template based on the (for now) not exported as TS https://github.com/algolia/instantsearch.js/blob/master/src/index.ts * update import method * correct file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since algolia/instantsearch#4844 the UMD has type definitions exposed, which we can use in codesandbox, even when the file itself isn't written in TypeScript, or using modules