Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

feat(release): Use release-it for releasing #40

Merged
merged 4 commits into from
Jun 11, 2018

Conversation

francoischalifour
Copy link
Member

No description provided.

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@francoischalifour
Copy link
Member Author

@Haroenv I didn't see your review but decided to remove the dry run release scripts and to not run the tests before releasing. What do you think?

@Haroenv
Copy link
Contributor

Haroenv commented Jun 8, 2018

Hmm, even though the tests are a bit slow when you want to do a release, it's useful as a last resort, I've accidentally released stuff which didn't pass the tests before

@francoischalifour
Copy link
Member Author

I will add them back, then!

@francoischalifour francoischalifour merged commit 054a755 into master Jun 11, 2018
@francoischalifour francoischalifour deleted the feat/release-it branch June 11, 2018 09:10
aymeric-giraudet pushed a commit to algolia/instantsearch that referenced this pull request Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants