This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix(angular): use instantsearch.css styles directly #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Haroenv
approved these changes
Jan 3, 2019
|
e2e tests need to be updated though (snapshots) |
francoischalifour
suggested changes
Jan 3, 2019
tkrugg
force-pushed
the
fix/angular-styles
branch
from
6bac76b
to
30e9c6c
Compare
francoischalifour
approved these changes
Jan 14, 2019
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out about this while writing the customization guide for angular.
Right now it seems we don't adovcate for using
instantsearch.cssstyles directly.After this is merged, we'd need to release and regenerate the samples in https://github.com/algolia/doc-code-samples/tree/master/Angular%20InstantSearch