Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

fix(cli): provide more context to user for searchable attribute #149

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

bobylito
Copy link
Contributor

With this change, we provide more information about what we're talking about and what is the goal of the question :)

@francoischalifour
Copy link
Member

We iterated on this CLI question with @sarahdayan a few weeks ago and came to the conclusion that "Main attribute" was not really explicit. We thought of these two options:

  • Attribute to display
  • Attribute to highlight

Thinking back about it, I reckon "Attribute to display" is more explicit. We should definitely add an explanation of what this property is used for.

We can use new lines and the suffix option from Inquirer.js to make the UI a bit better. Here is what I suggest:

preview

{
  type: 'list',
  name: 'mainAttribute',
  message: 'Attribute to display',
  suffix: `\n  ${chalk.gray('Used to generate the default result template')}`,
  // ...
}

Let me know if you agree. If so, I can take the PR over as I already have the working CLI locally.

@bobylito
Copy link
Contributor Author

Ok that's cool by me 👍

@francoischalifour francoischalifour merged commit 1ccd5b9 into master Jul 25, 2018
@francoischalifour francoischalifour deleted the bobylito-patch-1 branch July 25, 2018 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants